Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] translate SDK configurations #6532

Merged
merged 7 commits into from
Mar 13, 2025
Merged

[ja] translate SDK configurations #6532

merged 7 commits into from
Mar 13, 2025
+403 −0

Conversation

ymotongpoo
Copy link
Contributor

@ymotongpoo ymotongpoo requested a review from a team as a code owner March 12, 2025 02:07
@opentelemetrybot opentelemetrybot requested review from a team March 12, 2025 02:07
@ymotongpoo
Copy link
Contributor Author

@katzchang yoro-desu

katzchang
katzchang approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@katzchang katzchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ymotongpoo Looks good!

@katzchang katzchang added the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Mar 12, 2025
@opentelemetrybot opentelemetrybot requested review from a team March 13, 2025 00:24
katzchang
katzchang requested changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@katzchang katzchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ymotongpoo Added a few review omissions

@opentelemetrybot opentelemetrybot requested a review from a team March 13, 2025 00:41
@ymotongpoo
Copy link
Contributor Author

@katzchang thank you for catching those. naoshimashita~

katzchang
katzchang approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@katzchang katzchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved🙆

@chalin chalin mentioned this pull request Mar 13, 2025
Open
@chalin chalin added this pull request to the merge queue Mar 13, 2025
Merged via the queue into open-telemetry:main with commit 7c3256f Mar 13, 2025
18 checks passed
cijothomas pushed a commit to cijothomas/opentelemetry.io that referenced this pull request Mar 14, 2025
@ymotongpoo @cijothomas
[ja] translate SDK configurations (open-telemetry#6532)
bc6304e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katzchang katzchang katzchang approved these changes

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer lang:ja
Projects
SIG Comms: Docs Translation
Status: Done
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ymotongpoo @katzchang @chalin